Skip to content

NEST-SONATA: Enclose pandas import in try block#2843

Merged
heplesser merged 1 commit intonest:masterfrom
nicolossus:nestsonata_pandas
Jun 28, 2023
Merged

NEST-SONATA: Enclose pandas import in try block#2843
heplesser merged 1 commit intonest:masterfrom
nicolossus:nestsonata_pandas

Conversation

@nicolossus
Copy link
Member

@nicolossus nicolossus commented Jun 27, 2023

Enclosing the pandas import in a try block allows NEST to be built even if pandas is not installed. pandas is still a requirement for NEST-SONATA and an error will be raised if the SonataNetwork class is instantiated without pandas installed.

@nicolossus nicolossus added the S: High Should be handled next label Jun 27, 2023
@nicolossus nicolossus added this to the NEST 3.5 milestone Jun 27, 2023
@nicolossus nicolossus requested review from heplesser and jougs June 27, 2023 20:54
jougs
jougs approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@jougs jougs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@heplesser heplesser merged commit 2d2517a into nest:master Jun 28, 2023
@nicolossus nicolossus deleted the nestsonata_pandas branch June 28, 2023 08:02
@terhorstd
Copy link
Contributor

terhorstd commented Jun 28, 2023

Thanks for the quick solution, @nicolossus !

@jougs
Copy link
Contributor

jougs commented Jun 28, 2023

@terhorstd: Does that also mean that you are happy with the solution? ;-)

@terhorstd terhorstd mentioned this pull request Jul 1, 2023
Merged
heplesser added a commit that referenced this pull request Jul 3, 2023
@heplesser
Merge pull request #2849 from nest/3.5-develop-2843-2838-2830
d2f85ba 
Add cherry-picked changes from #2843, #2838, and #2830
@terhorstd terhorstd added T: Bug Wrong statements in the code or documentation I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heplesser heplesser heplesser approved these changes

@jougs jougs jougs approved these changes

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation

Projects

None yet

Milestone

NEST 3.5

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolossus @terhorstd @jougs @heplesser

Comments