Set correct virtual model name in NEST-SONATA documentation#2826
Merged
jessica-mitchell merged 4 commits intonest:masterfrom Jun 23, 2023
Merged
Set correct virtual model name in NEST-SONATA documentation#2826jessica-mitchell merged 4 commits intonest:masterfrom
jessica-mitchell merged 4 commits intonest:masterfrom
Conversation
nicolossus
added
S: Normal
Member
Author
|
@jessica-mitchell The failing CI was due to a formatting error in master which was fixed by #2837. Could you retrigger the CI? |
jessica-mitchell
requested changes
Jun 23, 2023
Contributor
jessica-mitchell
left a comment
jessica-mitchell
left a comment
There was a problem hiding this comment.
Looks good, just one minor suggestion
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
jessica-mitchell
approved these changes
Jun 23, 2023
Contributor
|
Merging with 1 reviewer as its doc related |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEST-SONATA uses the
spike_train_injectoras virtual model (used to bespike_generator). This PR changes the name of the virtual model to the correct one in places that were overlooked when the switch of models took place. The PR also improves the formatting by removing trailing whitespaces.