Merged
Conversation
Contributor
|
The key point here was that prior to #704 which fixed #545, NEST would actually crash when |
Member
|
@otcathatsya Can you please pull master into this branch so that you get the CI pipeline with the black checker enabled? |
db06d40 to
ef70258
Compare
heplesser
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the original SLI test may not have covered the intended error case to begin with? The original report specifies that passing integers leads to a crash/exception, though the SLI test seems to use floats only. In either case this is not an issue with python, as even integers are correctly cast.
Edit: it appears that a 2021 commit removed the integer part of the original SLI test since it became obsolete, purpose of the current test is a bit questionable