Port test-set-start-stop-origin.sli from Sli-2-Py#2757
Merged
heplesser merged 5 commits intonest:masterfrom Nov 28, 2023
Merged
Port test-set-start-stop-origin.sli from Sli-2-Py#2757heplesser merged 5 commits intonest:masterfrom
test-set-start-stop-origin.sli from Sli-2-Py#2757heplesser merged 5 commits intonest:masterfrom
Conversation
nicolossus
suggested changes
May 15, 2023
Member
nicolossus
left a comment
nicolossus
left a comment
There was a problem hiding this comment.
Thanks! Looks good overall, but I think some documentation should be added to the tests. See suggestions.
Contributor
|
@med-ayssar Remember to merge master to activate black-testing. |
nicolossus
added
S: Normal
nicolossus
approved these changes
Oct 17, 2023
Contributor
|
Resolved conversations as @nicolossus who had raised the issues has approved the PR. Ready to merge. |
heplesser
changed the title
test-set-start-stop-origin.sli from Sli-2-Py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.