Make calcium concentration available for setting#2627
Merged
heplesser merged 5 commits intonest:masterfrom Jun 22, 2023
Merged
Conversation
terhorstd
added
T: Enhancement
med-ayssar
suggested changes
Mar 16, 2023
Contributor
med-ayssar
left a comment
med-ayssar
left a comment
There was a problem hiding this comment.
Otherwise, the rest looks fine.
nicolossus
suggested changes
May 24, 2023
Member
nicolossus
left a comment
nicolossus
left a comment
There was a problem hiding this comment.
@clinssen Thanks! The addition to the kernel looks good. However, I would like to see some changes to the corresponding test code, see clinssen#7.
Moreover, could you pull master, so that the new directory structure and CI pipeline are merged?
nicolossus
reviewed
Jun 7, 2023
Co-authored-by: Nicolai Haug <39106781+nicolossus@users.noreply.github.com>
Contributor
|
Looks good! |
med-ayssar
approved these changes
Jun 13, 2023
Member
|
@heplesser Ping! |
heplesser
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check that we can set and get calcium concentration for all nodes that inherit from the
StructuralPlasticityNode.