Modernize the codebase - and, or, not#2498
Conversation
|
Unfortunately, two of the checks do not pass yet, because of some SLI regression test failing. I went over every single of my changes in this PR multiple times now and could not find any change that would actually change the compiled code in any way. All changes are purely style-based. Either I am missing something, or there is some reason related to SLI that I am not aware of, that causes the checks to fail. Could someone assist me here? |
|
@JanVogelsang I can at least explain why only two of the tests fail: The passing ones include MPI, and the test is skipped for MPI (for technical reasons). Can you reproduce the test failure on your computer if you build without MPI? |
|
I can reproduce the failing tests on my computer without building with MPI. Same error |
heplesser
left a comment
heplesser
left a comment
There was a problem hiding this comment.
I think I found the error, see suggestion.
There was a problem hiding this comment.
I guess the replacement of the operators is unproblematic here. I still have a bunch of other comments regarding the statements in the lines that change. Most of my comments also apply to other places in the code in addition to the ones I have marked.
jougs
left a comment
jougs
left a comment
There was a problem hiding this comment.
Thanks for taking care of this. It is really much appreciated :-)
Co-authored-by: Jochen Martin Eppler <jougs@gmx.net>
jougs
changed the title
jougs
added
S: Normal
3 participants
In this PR all occurrences of
&&,||and!are changed toand,orandnotrespectively.Additionally, all redundant parentheses around boolean expressions are removed.
e.g.:
if ( ( a == 1 ) && ( b == 2 ) )was changed toif ( a == 1 and b == 2 )