Validate Openshift limit ranges#264
Merged
knikolla merged 1 commit intonerc-project:mainfrom Nov 6, 2025
Merged
Conversation
QuanMPhm
force-pushed
the
257/limit_ranges
branch
from
4e39986 to
95f5a02
Compare
knikolla
requested changes
Nov 5, 2025
knikolla
requested changes
Nov 5, 2025
src/coldfront_plugin_cloud/tests/functional/openshift/test_allocation.py
Outdated
Show resolved
Hide resolved
QuanMPhm
force-pushed
the
257/limit_ranges
branch
3 times, most recently
from
762e452 to
8dd9d76
Compare
Contributor
Author
|
@knikolla Pinging since the UI won't let me re-request your review |
knikolla
requested changes
Nov 5, 2025
QuanMPhm
force-pushed
the
257/limit_ranges
branch
from
8dd9d76 to
2ea2b67
Compare
knikolla
requested changes
Nov 6, 2025
knikolla
reviewed
Nov 6, 2025
QuanMPhm
force-pushed
the
257/limit_ranges
branch
from
2ea2b67 to
ead0591
Compare
knikolla
requested changes
Nov 6, 2025
knikolla
requested changes
Nov 6, 2025
A function `set_project_configuration()` has been added to `openshift.py` to validate limit ranges. This allows changes to the default limit ranges (`LIMITRANGE_DEFAULTS`) to be applied to pre-existing Openshift projects. The plan will be for this function to eventually contain all validation logic for Openshift project configurations, allowing `validation_allocations` to be resource-agnostic. New functional and unit test cases added
QuanMPhm
force-pushed
the
257/limit_ranges
branch
from
ead0591 to
df2cc66
Compare
knikolla
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257.
A function
set_project_configuration()has been added toopenshift.pyto validate limit ranges. This allows changes to the default limit ranges (LIMITRANGE_DEFAULTS) to be applied to pre-existing Openshift projects.The plan will be for this function to eventually contain all validation logic for Openshift project configurations, allowing
validation_allocationsto be resource-agnostic.New functional test case added
parse_quota_valuehas been moved toutils.pyas it is now used in two places