Adding PackageRevision Deletion Guide #292
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for nephio ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Catalin-Stratulat-Ericsson
requested review from
CsatariGergely,
efiacor and
lovesprung
CsatariGergely
left a comment
CsatariGergely
left a comment
There was a problem hiding this comment.
Shoudn't we name the files *-package-revisions.md?
sure thing! these file names were from before changing the wording in them to package-revision to try and clarify the term from "packages" |
thinking a bit further on this. would it be possible to do this in a separate PR for all guides under "working with package revisions" to avoid any relref link breaks like last time? |
| porchctl rpkg get --namespace=default | ||
| ``` | ||
|
|
||
| You should see output similar to: |
There was a problem hiding this comment.
| You should see output similar to: | |
| You should see an output similar to: |
| - Deletes the corresponding Git branch (`draft/draft-v1`) | ||
| - No approval or confirmation required | ||
|
|
||
| **Verify deletion:** |
There was a problem hiding this comment.
| **Verify deletion:** | |
| **Verify the deletion:** |
| - Deletes the corresponding Git branch (`proposed/proposed-v1`) | ||
| - No approval process required | ||
|
|
||
| **Verify deletion:** |
There was a problem hiding this comment.
| **Verify deletion:** | |
| **Verify the deletion:** |
|
|
||
| ## Step 5a: Approve Deletion Proposal | ||
|
|
||
| If you want to proceed with deletion, approve the deletion proposal: |
There was a problem hiding this comment.
| If you want to proceed with deletion, approve the deletion proposal: | |
| If you want to proceed with the deletion, approve the deletion proposal: |
|
|
||
| - Permanently deletes the PackageRevision | ||
| - Removes the Git tag and any associated branches | ||
| - Cannot be undone once completed |
There was a problem hiding this comment.
| - Cannot be undone once completed | |
| - **Important**: This cannot be undone once completed |
There was a problem hiding this comment.
i'd try to highlight this somehow cause it looks important, hence the Important but other solutions are fine too. just wouldn't want the reader to skim over this
|
|
||
| ## Batch Deletion Operations | ||
|
|
||
| You can delete multiple PackageRevisions in a single command: |
There was a problem hiding this comment.
| You can delete multiple PackageRevisions in a single command: | |
| You can delete multiple PackageRevisions with a single command: |
|
|
||
| **PackageRevision not found:** | ||
|
|
||
| - Verify the exact PackageRevision name: `porchctl rpkg get --namespace=default` |
There was a problem hiding this comment.
| - Verify the exact PackageRevision name: `porchctl rpkg get --namespace=default` | |
| - Verify the exact PackageRevision name with the `porchctl rpkg get --namespace=default` command |
|
|
||
| **Permission denied:** | ||
|
|
||
| - Check RBAC permissions: `kubectl auth can-i delete packagerevisions -n default` |
There was a problem hiding this comment.
| - Check RBAC permissions: `kubectl auth can-i delete packagerevisions -n default` | |
| - Check RBAC permissions with the `kubectl auth can-i delete packagerevisions -n default` command |
|
|
||
| **Deletion proposal stuck:** | ||
|
|
||
| - Check the PackageRevision status: `porchctl rpkg get <name> -o yaml` |
There was a problem hiding this comment.
| - Check the PackageRevision status: `porchctl rpkg get <name> -o yaml` | |
| - Check the PackageRevision status with the `porchctl rpkg get <name> -o yaml` command |
| porchctl rpkg get --namespace=default | ||
| ``` | ||
|
|
||
| You might see output like: |
There was a problem hiding this comment.
| You might see output like: | |
| You might see an output like: |
3 participants
Adds an guide detailing how to perform the delete operation correctly, deleting at different stages of the lifecycle.
Explicitly detailing how the "main" revision should be taken care of in such situations also.