Skip to content

Address missed comments from PR #203 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nephio-prow merged 1 commit into from
Feb 24, 2025
Merged

Address missed comments from PR #203 #207

nephio-prow merged 1 commit into from
Feb 24, 2025

Conversation

@efiacor
Copy link
Collaborator

@efiacor efiacor commented Feb 13, 2025

@nephio-prow nephio-prow bot requested review from liamfallon and s3wong February 13, 2025 22:31
@netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 65aa6f8
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/67ae72be7f746e0008cf33f5
😎 Deploy Preview https://deploy-preview-207--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@efiacor efiacor mentioned this pull request Feb 13, 2025
Merged
@efiacor efiacor requested review from CsatariGergely and removed request for s3wong February 13, 2025 22:32
@efiacor efiacor self-assigned this Feb 13, 2025
@efiacor efiacor added the documentation Improvements or additions to documentation label Feb 13, 2025
liamfallon
liamfallon reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@nephio-prow nephio-prow bot added the approved label Feb 17, 2025
@efiacor efiacor mentioned this pull request Feb 19, 2025
Merged
vjayaramrh
vjayaramrh approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@vjayaramrh vjayaramrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@liamfallon
Copy link
Member

liamfallon commented Feb 20, 2025

@CsatariGergely Does this address your comments?

@liamfallon
Copy link
Member

liamfallon commented Feb 24, 2025

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Feb 24, 2025
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon, vjayaramrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit b5ebfdb into nephio-project:main Feb 24, 2025
8 checks passed
@efiacor efiacor deleted the address_missed_comments_from_203 branch February 25, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liamfallon liamfallon liamfallon left review comments

@CsatariGergely CsatariGergely Awaiting requested review from CsatariGergely

+1 more reviewer

@vjayaramrh vjayaramrh vjayaramrh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liamfallon liamfallon

@efiacor efiacor

Labels

approved documentation Improvements or additions to documentation lgtm

Projects

Nephio Project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efiacor @liamfallon @vjayaramrh