Skip to content

Add CMakeLists.txt and support for MSVC #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2019
Merged

Add CMakeLists.txt and support for MSVC #3

merged 3 commits into from
Aug 8, 2019

Conversation

@b-r-o-c-k
Copy link

@b-r-o-c-k b-r-o-c-k commented Jul 11, 2019

No description provided.

@blueyed
Copy link

blueyed commented Aug 3, 2019

@b-r-o-c-k
Thanks for this already.
Do you think we could/should have tests/CI using AppVeyor for/with this?

@blueyed
Copy link

blueyed commented Aug 7, 2019

Rebased, and added a job to build with CMake.

@blueyed
Copy link

blueyed commented Aug 7, 2019

Tested that it is really using the lib built with CMake in 6c6351c (https://travis-ci.com/neovim/unibilium/jobs/223220172).

@blueyed blueyed mentioned this pull request Aug 7, 2019
Open
@blueyed
Copy link

blueyed commented Aug 8, 2019

@b-r-o-c-k
Is this good / ready from your side?

@b-r-o-c-k
Copy link
Author

b-r-o-c-k commented Aug 8, 2019

Yes, looks good!

@blueyed blueyed merged commit baaf024 into neovim:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmk justinmk justinmk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@b-r-o-c-k @blueyed @justinmk