Skip to content

Rename volar to vue_ls and remove vuels #3843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

Rename volar to vue_ls and remove vuels #3843

merged 2 commits into from
May 21, 2025

Conversation

@Jak-Ch-ll
Copy link
Contributor

@Jak-Ch-ll Jak-Ch-ll commented May 11, 2025 •
edited
Loading

Closes #3826

A few questions:

  1. Is there a good way with the new configs to alias an older name, so it stays available?
    • I found the aliases table, but this seems to only affect the old configs.
    • For the new configs I kept the lsp/volar.lua file, added a vim.deprecate, and returned vim.lsp.config.vue_ls
  2. What is a good version to remove it later? I used 3.0.0 as placeholder

Additionally (even though not super necessary), I couldn't check the generated docs because nvim -R -Es +'set rtp+=$PWD' +'luafile scripts/docgen.lua' fails without message for me

  • Running luafile scripts/docgen.lua' inside of Neovim (even after adding the path to rtp) fails with the error scripts/docgen.lua:136: module 'lsp.ada_ls' not found
  • Do I need to setup anything locally?

@Jak-Ch-ll Jak-Ch-ll mentioned this pull request May 11, 2025
Closed
@Jak-Ch-ll Jak-Ch-ll force-pushed the rename-volar branch 2 times, most recently from ad90d68 to ad73ffa Compare May 11, 2025 13:53
Jak-Ch-ll added 2 commits May 11, 2025 15:54
@Jak-Ch-ll
feat(volar)!: rename to 'vue_ls'
221bc7b 
The Vue language tooling does not use 'Volar' prominently in its
documentation. The official name for the language server is
'@vue/language-server'.
@Jak-Ch-ll
chore(vuels): remove config
5b7f09a 
This project is no longer active. Use [vue_ls](lsp/vue_ls.lua) instead.
@Jak-Ch-ll
Copy link
Contributor Author

Jak-Ch-ll commented May 11, 2025 •
edited
Loading

Removed my changes to the old configs, as per lint rules

@justinmk
Copy link
Member

justinmk commented May 21, 2025

  • For the new configs I kept the lsp/volar.lua file, added a vim.deprecate, and returned vim.lsp.config.vue_ls

exactly 👍

@justinmk
Copy link
Member

justinmk commented May 21, 2025

  • Running luafile scripts/docgen.lua' inside of Neovim (even after adding the path to rtp) fails with the error scripts/docgen.lua:136: module 'lsp.ada_ls' not found
  • Do I need to setup anything locally?

that's strange. shouldn't happen

@justinmk justinmk merged commit 2864899 into neovim:master May 21, 2025
10 checks passed
@mehalter mehalter mentioned this pull request May 21, 2025
Merged
3 tasks
@gx089 gx089 mentioned this pull request May 22, 2025
Closed
@dragunovartem99 dragunovartem99 mentioned this pull request Jun 7, 2025
Closed
@wvffle wvffle mentioned this pull request Aug 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename volar and sunset vuels

2 participants

@Jak-Ch-ll @justinmk