What if we used 2 spaces, though? #62
Conversation
|
personally i prefer 4 spaces, curios why we are changing it. |
|
I personally don't care one way or the other as long as we're consistent. And I'm not really a C# guy so I don't know what the meta is. |
|
I'd agree on 4 spaces |
|
ive opened pr #63 to update the editor config to match the current contributing.md |
|
Okay so iirc I just quickly looked at the csproj files, saw 2 spaces, and went "oh okay this is what's been used" without properly checking the cs files x'D the |
.github/CONTRIBUTING.md
Outdated
| - *.cs files | ||
| - Lines MUST be indented using four spaces. Tabs are not acceptable. | ||
| - Lines MUST be indented using two spaces. Tabs are not acceptable. | ||
| - MUST use unix-style (LF) line endings. CR or CRLF are not acceptable. | ||
| - *.sln files: use the Visual Studio defaults | ||
| - indent using tabs | ||
| - *.sln files | ||
| - indent using two spaces | ||
| - CRLF line endings | ||
| - *.csproj files: use the Visual Studio defaults | ||
| - *.csproj files | ||
| - indent using two spaces | ||
| - CRLF line endings | ||
|
|
There was a problem hiding this comment.
.... I really want to have one unified style for everything instead of 3 different ones though.
zkxs
changed the title
|
*.csproj and *.sln are now formatted using 2 spaces and LF. I've removed human-readable whitespace guidelines from CONTRIBUTING.md as they are superseded by editorconfig. This brings the PR in line with tab and 4-space PRs, so I've edited the title and description to match. |
l-2-j
left a comment
l-2-j
left a comment
There was a problem hiding this comment.
I mean, I can also agree on 2 spaces since it's not as big as 4, and what I've configured my tab size as
|
#65 seems to be the best option as it allows you to change the visual based on your preference within your editor |
|
#65 is the ultimate winner. |
Changes everything to two spaces. Removes human-readable whitespace guidelines from CONTRIBUTING.md as they are superseded by editorconfig.
dotnet formatdoesn't run on csproj or sln files so I've formatted them manually.THE PRS WILL CONTINUE
UNTIL MORALE IMPROVES