Skip to content

Conversation

@dherman
Copy link
Contributor

@dherman dherman commented May 21, 2020

This RFC modifies the design of RFC 25 with a solution to handling JavaScript exceptions that might get thrown during the process of launching the event handler.

Rendered RFC

- Trim down the recap of RFC 25
- Remove the unnecessary `.upcast()` from the `schedule()` example
- Mention that `try_catch()` could be useful in the implementation of `schedule_with()`
@dherman dherman added the final comment period last opportunity to discuss the proposed conclusion label May 29, 2020
@dherman
Copy link
Contributor Author

dherman commented May 29, 2020

This RFC is entering final comment period! If there's no more significant discussion in the next 7 days, it will be accepted and merged!

@dherman dherman merged commit eacf9d9 into neon-bindings:master Jun 13, 2020
@dherman dherman deleted the exception-safe-event-handlers branch June 13, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

final comment period last opportunity to discuss the proposed conclusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants