Skip to content

Global object method change #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2023
Merged

Global object method change #987

merged 3 commits into from
Jun 2, 2023

Conversation

@dherman
Copy link
Collaborator

@dherman dherman commented May 27, 2023 •
edited
Loading

From the list of remaining breaking changes:

  • Change the existing Context::global() method to Context::global_object()
  • Add a convenience method Context::global(name) that looks up a global value by name

@dherman dherman requested a review from kjvalencik May 27, 2023 18:53
@dherman dherman mentioned this pull request May 29, 2023
Merged
@dherman dherman merged commit 5f629b9 into main Jun 2, 2023
@dherman dherman deleted the global_object branch June 2, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjvalencik kjvalencik kjvalencik approved these changes

Assignees

No one assigned

Labels

API breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dherman @kjvalencik