Skip to content

Conversation

@kjvalencik
Copy link
Member

@kjvalencik kjvalencik commented Feb 27, 2023

There have been multiple examples where users would like to do something that extends Neon, but requires direct access to Node-API. Sometimes these features to not align with Neon's philosophy.

As an escape hatch, we provide an unsafe sys feature that exposes Node-API and conversions to and from Neon types.

@kjvalencik kjvalencik marked this pull request as ready for review March 17, 2023 16:28
@kjvalencik kjvalencik changed the title feat(neon): Sys feat(neon): sys feature to give access to Node-AP Mar 17, 2023
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing. Just a few small suggestions and a couple clarifying questions. I don't think you need a re-review after making any tweaks.

@kjvalencik kjvalencik changed the title feat(neon): sys feature to give access to Node-AP feat(neon): sys feature to give access to Node-API Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants