JsBigInt #963
Merged
JsBigInt #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherman
requested changes
Feb 10, 2023
Collaborator
dherman
left a comment
dherman
left a comment
There was a problem hiding this comment.
I love the API and the code is super clean and straightforward. And my god, it's full of tests…
I left one suggestion for a name change (Error -> RangeError) and some docs suggestions.
dherman
approved these changes
Feb 17, 2023
Collaborator
dherman
left a comment
dherman
left a comment
There was a problem hiding this comment.
Looks great! I'd just add the endianness formula to read_digits_le as well.
Co-authored-by: Matthew Little <[email protected]>
kjvalencik
force-pushed
the
kv/bigint
branch
from
bd4fbd9 to
2fa6653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.