fix(cargo-cp-artifact): Unlink .node files before copying to flush macOS code signature cache #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cOS code signature cache Resolves #911
dherman
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
LGTM.
Eventually we'll want to have a docs page to help people deal with what will still likely be a common pitfall, when other parts of their build or packaging process happens to edit some .node file in-place. We can't protect against whatever they might do in their custom builds, so we'll probably end up needing some sort of troubleshooting guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #911