Skip to content

Conversation

@MikaelUrankar
Copy link
Contributor

No description provided.

@MikaelUrankar
Copy link
Contributor Author

Your CI seems broken

@kjvalencik
Copy link
Member

This looks good, but FYI, this is updating the legacy backend which is deprecated and will be removed in 1.0. Is there a reason your project is unable to move to the Node-API backend?

Concerning CI, only Windows is broken. There is a fix in another PR that I haven't cherry picked. It broke when GitHub upgraded the Windows runners. Unfortunately, the legacy backend is very sensitive to versions.

@kjvalencik kjvalencik merged commit cbd46c8 into neon-bindings:main Feb 19, 2022
@MikaelUrankar
Copy link
Contributor Author

This looks good, but FYI, this is updating the legacy backend which is deprecated and will be removed in 1.0. Is there a reason your project is unable to move to the Node-API backend?

It's not my project, signal-desktop uses this crate: https://github.com/signalapp/ringrtc/blob/master/src/rust/Cargo.toml#L59

@kjvalencik
Copy link
Member

kjvalencik commented Feb 19, 2022

Thanks for the info! It looks like it's already using the Node-API code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants