perf: Performance improvements for Node-API backend #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node-API creates handle scopes as part of the environment. Creating an explicit scope is only necessary for `Context::compute_scoped` and `Context::execute_scoped`.
kjvalencik
commented
Oct 28, 2021
Additionally, avoids initialization of allocated space
kjvalencik
force-pushed
the
kv/easy-perf-wins
branch
from
4f84681 to
a417371
Compare
dherman
approved these changes
Oct 30, 2021
Collaborator
dherman
left a comment
dherman
left a comment
There was a problem hiding this comment.
Looks good! The TODO comment gave me one idea for a maintenance practice, see what you think.
| } | ||
|
|
||
| /// Gets the number of arguments passed to the function. | ||
| // TODO: Remove this when `CallContext` is refactored to get call info upfront. |
Collaborator
There was a problem hiding this comment.
Idea: would it be useful to label TODO comments with labels for the future trigger that will allow the action to be taken, e.g. TODO(remove-legacy)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to
raw::InheritedScopeis the more significant improvement. Theargvchange is more minor.tl;dr -- We were always creating handle scopes on function calls, but Node-API has already done it for us. It's only necessary to create a scope for
execute_scopedandcompute_scoped.