Fix RxSession in Testkit Backend #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testkit environment variables without `TEST_` prefix are not forward by the Testkit to the scripts in the driver. So we need change the session type variable expected by the `backend.py` to be `TEST_SESSION_TYPE` and then remove the prefix before redirect to the backend. This PR also fix the `SessionRun` and `TransactionRun` to not initate the stream.
Improves the RxSession.beginTransaction by make it failing in the correct observable.
Contributor
Author
|
Depends on: neo4j-drivers/testkit#512 |
fbiville
reviewed
Aug 30, 2022
fbiville
reviewed
Aug 30, 2022
Co-authored-by: Florent Biville <[email protected]>
Trying to logging broken objects was causing the driver fails in unexpected moments. This broken behaviour makes the driver fail different when the `debug` log is enabled.
fbiville
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testkit environment variables without
TEST_prefix are not forward by the Testkit to thescripts in the driver. So we need change the session type variable expected by the
backend.pyto be
TEST_SESSION_TYPEand then remove the prefix before redirect to the backend.This PR also fix the
SessionRunandTransactionRunto not initiate the stream.Warn:
RxSession.beginTransactionandRxSession.execute*were tweaked. TheObservable<RxTransaction>only emits theRxTransactionwhen the begin is executed with success. The begin still defer the execution to the point observer is subscribed.