Add support for error cause in Neo4jError and Routing errors #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root causes of routing issue were suppressed by the routing error message. This change enables the `Neo4jError` object use the `cause` property for giving more context about the error. This also improves the routing error by making use of the error `cause`. `Error.cause` is a new feature in JS, see which runtime already implemented it: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error
robsdedude
approved these changes
Jul 5, 2022
packages/bolt-connection/src/connection-provider/connection-provider-routing.js
Show resolved
Hide resolved
Co-authored-by: Robsdedude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root causes of routing issue were suppressed by the routing error message.
This change enables the
Neo4jErrorobject use thecauseproperty for giving more context about the error. Thisalso improves the routing error by making use of the error
cause.Error.causeis a new feature in JS, see which runtime already implemented it:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Error