Refactory Pool module
#930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state of the pool and the resource list weren't bounded togheter as it supposed to. This scenario makes the code prune to bugs and incosistency in the long run. Merge the resouse list (a.k.a. Pool) and PoolState in the same object makes the code easier to understand and more coesive.
bigmontz
force-pushed
the
5.0-make-pools-great-again
branch
from
27adb14 to
4a47a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state of the pool and the resource list weren't bounded together as it supposed to. This scenario makes the code prune to bugs and inconsistency in the long run.
Merge the resource list (a.k.a. Pool) and PoolState in the same object makes the code easier to understand and more cohesive.