Prevent iterate over already consumed Result #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
changed the title
Contributor
Author
|
Depends on: neo4j-drivers/testkit#420 |
robsdedude
reviewed
Mar 14, 2022
bigmontz
force-pushed
the
5.0-result-scope
branch
from
874c103 to
d52d7e4
Compare
This `result.then` and `for await (const r of result)` in already consumed results could block for ever since no new event will came from wire. Blocking this kind of access improves not correct access to the Result object. This change also includes the addition of `Result.isOpen()`
Co-authored-by: Robsdedude <[email protected]>
bigmontz
force-pushed
the
5.0-result-scope
branch
from
d52d7e4 to
22a61ec
Compare
bigmontz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for await (const r of result)in already consumed results could block for ever since no new event will came from wire.Blocking this kind of access improves not correct access to the Result object.
This change also includes the addition of
Result.isOpen()