Skip to content

Conversation

@bigmontz
Copy link
Contributor

@bigmontz bigmontz commented Mar 8, 2022

Allowing self-manage managed transactions could causing unexpected behaviours in the user code depends on how the different possible code paths in the transaction work.

@bigmontz
Copy link
Contributor Author

bigmontz commented Mar 8, 2022

Depends on: neo4j-drivers/testkit#415

@bigmontz bigmontz changed the title Doesn't allow .commit(), .rollback() or .close() managed transactions Deprecate .commit(), .rollback() or .close() managed transactions Mar 9, 2022
@bigmontz
Copy link
Contributor Author

bigmontz commented Mar 9, 2022

Depends on: neo4j-drivers/testkit#415

Not anymore

Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@bigmontz bigmontz merged commit ed365bd into neo4j:5.0 Mar 11, 2022
@bigmontz bigmontz deleted the 5.0-tx-lifetime branch March 11, 2022 13:29
bigmontz added a commit that referenced this pull request Apr 4, 2022
bigmontz added a commit that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants