Fix user agent #174
Merged
Fix user agent #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously was `neo4j-javascript/[object Object]` because of an incorrect usage of default import. This commit makes it `neo4j-javascript/0.0.0-dev`. Part after `/` will be changed by the pre-release gulp script.
Command `gulp set --version <VERSION>` was meant to change version in `version.js` which is later used in driver's user agent. However it tried to modify `package.json` file instead of `version.js`. This commit makes it operate on the correct file.
Version is set in `package.json` (used as npm package version) and in
`src/version.js` (used to create driver's user agent string).
Script is named `versionRelease` and requires `VERSION` env variable to be set.
Examples:
```
VERSION=1.1.5 npm run versionRelease
VERSION=1.1.5-rc01 npm run versionRelease
VERSION=1.1.5-alpha03 npm run versionRelease
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.