Fix BrowserChannel close when is already closing #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebSockets can take a while for closing and the `WebSocket.close` is called when status is `WS_CLOSING`, an error is thrown. This situation can happen when the driver is being closed while session still releasing connections back to the pool or after a receive timeout while closing the session. BrowserChannel should wait for the original close socket finish whenever a new close request happens to avoid this kind of error and provides a graceful shutdown for driver and session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSockets can take a while for closing, and when
WebSocket.closeis called while the status isWS_CLOSING, an error is thrown.This situation can happen when the driver is being closed while sessions are still releasing connections back to the pool or after a receive timeout while closing the session.
BrowserChannel should wait for the original close socket to finish whenever a new close request happens to avoid this kind of error and provide a graceful shutdown for driver and session.