Add notificationFilter to the Config type
#1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `notificationFilter` config was not mapped correctly to the `Config` type. So, the driver was not offering the correct auto-complete and type support for this configuration on the `neo4j.driver` factory. The disconnection between the configuration object and the documentation was the root cause of the issue, since the filter was correctly documented. For solving this issue, the `Config` documentation was moved to live along with its definition. The interface was promoted to class to make it happen. Howevever, the class constructor can only be used internally and for the api point of view, the `Config` still behaving as an interface.
bigmontz
commented
Jun 8, 2023
Co-authored-by: Stefano Ottolenghi <[email protected]>
ConorNeo
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
notificationFilterconfig was not mapped correctly to theConfigtype. So, the driver was not offering the correct auto-complete and type support for this configuration on theneo4j.driverfactory.The disconnection between the configuration object and the documentation was the root cause of the issue, since the filter was correctly documented.
For solving this issue, the
Configdocumentation was moved to live along with its definition. The interface was promoted to class to make it happen. However, the class constructor can only be used internally and for the api point of view, theConfigstill behaving as an interface.