Clear receive timeout when close browser and Deno channels #1016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigmontz
force-pushed
the
5.x-remove-temporal-test-flakyness
branch
3 times, most recently
from
2730056 to
909e4c4
Compare
The receive timeout was not being clearer when channel get closed. With the timeout running, receive timeouts events can still be notified to the existing observers. This was causing some tests failing and possibile issues in production code.
bigmontz
force-pushed
the
5.x-remove-temporal-test-flakyness
branch
from
909e4c4 to
f00ca69
Compare
bigmontz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receive timeout was not being clearer when channel get closed.
With the timeout running, receive timeouts events can still be notified to the existing observers.
This was causing some tests failing and possible issues in production code.
This bug was found in the test
package/neo4j-driver/test/result.test.js (should handle missing onCompleted). This test was callingdonetwice because of a late failing coming to the observer.Node channels are not affected by this error since its timeout implementation is controlled to the socket.