Skip to content

Fail fast for more rediscovery failures #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Fail fast for more rediscovery failures #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f8d420
Fail fast on rediscovery when 'Neo.ClientError.Statement.ArgumentErro…
bigmontz Oct 26, 2022
4be1ea4
Fail fast on 'Neo.ClientError.Request.Invalid'
bigmontz Oct 28, 2022
1703009
Add `Neo.ClientError.Statement.TypeError` as failing fast error
bigmontz Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/bolt-connection/src/connection-provider/connection-provider-routing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ const INVALID_BOOKMARK_MIXTURE_CODE =
'Neo.ClientError.Transaction.InvalidBookmarkMixture'
const AUTHORIZATION_EXPIRED_CODE =
'Neo.ClientError.Security.AuthorizationExpired'
const INVALID_ARGUMENT_ERROR = 'Neo.ClientError.Statement.ArgumentError'
const INVALID_REQUEST_ERROR = 'Neo.ClientError.Request.Invalid'
const STATEMENT_TYPE_ERROR = 'Neo.ClientError.Statement.TypeError'

const SYSTEM_DB_NAME = 'system'
const DEFAULT_DB_NAME = null
Expand Down Expand Up @@ -703,7 +706,10 @@ function _isFailFastError (error) {
return [
DATABASE_NOT_FOUND_CODE,
INVALID_BOOKMARK_CODE,
INVALID_BOOKMARK_MIXTURE_CODE
INVALID_BOOKMARK_MIXTURE_CODE,
INVALID_ARGUMENT_ERROR,
INVALID_REQUEST_ERROR,
STATEMENT_TYPE_ERROR
].includes(error.code)
}

Expand Down
3 changes: 3 additions & 0 deletions packages/bolt-connection/test/connection-provider/connection-provider-routing.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,6 +1669,9 @@ describe.each([
'Neo.ClientError.Database.DatabaseNotFound',
'Neo.ClientError.Transaction.InvalidBookmark',
'Neo.ClientError.Transaction.InvalidBookmarkMixture',
'Neo.ClientError.Request.Invalid',
'Neo.ClientError.Statement.ArgumentError',
'Neo.ClientError.Statement.TypeError',
'Neo.ClientError.Security.Forbidden',
'Neo.ClientError.Security.IWontTellYou'
])('with "%s"', errorCode => {
Expand Down
8 changes: 7 additions & 1 deletion .../neo4j-driver-deno/lib/bolt-connection/connection-provider/connection-provider-routing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ const INVALID_BOOKMARK_MIXTURE_CODE =
'Neo.ClientError.Transaction.InvalidBookmarkMixture'
const AUTHORIZATION_EXPIRED_CODE =
'Neo.ClientError.Security.AuthorizationExpired'
const INVALID_ARGUMENT_ERROR = 'Neo.ClientError.Statement.ArgumentError'
const INVALID_REQUEST_ERROR = 'Neo.ClientError.Request.Invalid'
const STATEMENT_TYPE_ERROR = 'Neo.ClientError.Statement.TypeError'

const SYSTEM_DB_NAME = 'system'
const DEFAULT_DB_NAME = null
Expand Down Expand Up @@ -703,7 +706,10 @@ function _isFailFastError (error) {
return [
DATABASE_NOT_FOUND_CODE,
INVALID_BOOKMARK_CODE,
INVALID_BOOKMARK_MIXTURE_CODE
INVALID_BOOKMARK_MIXTURE_CODE,
INVALID_ARGUMENT_ERROR,
INVALID_REQUEST_ERROR,
STATEMENT_TYPE_ERROR
].includes(error.code)
}

Expand Down