Repository navigation
Update RxResultCursorImpl - #1580
Merged
Merged
Conversation
injectives
marked this pull request as draft
November 7, 2024 23:41
injectives
force-pushed
the
auth
branch
4 times, most recently
from
November 9, 2024 14:09
d8aa4ae to
945bbd0
Compare
| decrementDemand(); | ||
| } | ||
| recordConsumer.accept(record, null); | ||
| public synchronized boolean isDone() { |
There was a problem hiding this comment.
Minor thought. Perhaps this should be named isSuccessful or something like that as it only returns true on the SUCCEEDED case. Not important though.
AndyHeap-NeoTech
approved these changes
Nov 11, 2024
AndyHeap-NeoTech
left a comment
AndyHeap-NeoTech
left a comment
There was a problem hiding this comment.
One very minor comment on a method name that I'm not even sure needs changing :) The refactor looks good, approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.