Repository navigation
Call close with the appropriate flag to commit or rollback on UnmanagedTransaction where possible to avoid double state acquisition - #1065
Merged
Conversation
injectives
force-pushed
the
feature/async
branch
from
November 10, 2021 11:31
5705f9b to
1853b00
Compare
michael-simons
approved these changes
Nov 10, 2021
michael-simons
left a comment
michael-simons
left a comment
Contributor
There was a problem hiding this comment.
Maybe add to the commit message
Call
closewith the appropriate flag to commit or rollback onUnmanagedTransactionwhere possible to avoid double state aquisition.
Otherwise looks great.
…edTransaction where possible to avoid double state acquisition Calling `close` instead of separate `isOpen` and `commitAsync` requires less lock acquisitions and is safer.
injectives
force-pushed
the
feature/async
branch
from
November 10, 2021 11:53
1853b00 to
65b0a34
Compare
injectives
changed the title
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Nov 11, 2021
…edTransaction where possible to avoid double state acquisition (neo4j#1065) * Call close with the appropriate flag to commit or rollback on UnmanagedTransaction where possible to avoid double state acquisition Calling `close` instead of separate `isOpen` and `commitAsync` requires less lock acquisitions and is safer. * Update tests
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Nov 11, 2021
…edTransaction where possible to avoid double state acquisition (neo4j#1065) * Call close with the appropriate flag to commit or rollback on UnmanagedTransaction where possible to avoid double state acquisition Calling `close` instead of separate `isOpen` and `commitAsync` requires less lock acquisitions and is safer. * Update tests
injectives
added a commit
that referenced
this pull request
Nov 11, 2021
* Make UnmanagedTransaction return ongoing tx completion stage (#1057) This update ensures that `UnmanagedTransaction` returns existing on-going tx completion stage when a similar request is made. For instance, if it was requested to be rolled back and then requested to be closed, both invocations should get the same on-going stage. In addition, it should not accept conflicting actions, like committing and rolling back at the same time. In addition, it makes sure that cancellation on reactive transaction function results in rollback. * Call close with the appropriate flag to commit or rollback on UnmanagedTransaction where possible to avoid double state acquisition (#1065) * Call close with the appropriate flag to commit or rollback on UnmanagedTransaction where possible to avoid double state acquisition Calling `close` instead of separate `isOpen` and `commitAsync` requires less lock acquisitions and is safer. * Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
closeinstead of separateisOpenandcommitAsyncrequires less lock acquisitions and is safer.