Repository navigation
Draft PR to see if we can fix our flaky tests on this branch - #672
Draft
anderson4j wants to merge 2 commits into
Draft
anderson4j wants to merge 2 commits into
anderson4j wants to merge 2 commits into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried:
Updating testcontainers and @vscode/test-electron used by flaky step.
To try:
Modify "Switching the linter back to a new one should show different errors:" into the test "Switching the linter to an old one should show different errors" - had the idea that since only the prior fails the linter switching seems to work as expected at first. If the tests however were run in parallel, at times we might not do the switches in the order (instead of 2025.06 -> 5.26 -> 2025.06, we might be getting 2025.06 -> 2025.06 -> 5.26)