Skip to content

Handle ignored message as a failure#218

Merged
knutwalker merged 1 commit into
neo4j-labs:mainfrom
madchicken:add-ignore-protocol-v2
Jan 27, 2025
Merged

Handle ignored message as a failure#218
knutwalker merged 1 commit into
neo4j-labs:mainfrom
madchicken:add-ignore-protocol-v2

Conversation

@madchicken
Copy link
Copy Markdown
Collaborator

Description

This pull request includes a change to the error handling in the RowStream implementation in lib/src/stream.rs. The change ensures that the state is set to Complete(None) and an Error::RequestIgnoredError is returned when the summary is Ignored. This because the documentation states:

The IGNORED message indicates that the corresponding request has not been carried out.

For the RUN command the doc also says:

If the server is in a FAILED or INTERRUPTED state, the request will be IGNORED.

Error handling improvement:

  • lib/src/stream.rs: Modified the handling of Summary::Ignored to set the state to Complete(None) and return an Error::RequestIgnoredError.

Copy link
Copy Markdown
Contributor

@knutwalker knutwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knutwalker knutwalker merged commit 64c4ea5 into neo4j-labs:main Jan 27, 2025
@madchicken madchicken deleted the add-ignore-protocol-v2 branch January 27, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants