Skip to content

Update CI jobs to include feature flags #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knutwalker merged 3 commits into from
Jul 17, 2024
Merged

Update CI jobs to include feature flags #173

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
197bac5
Run CI jobs with feature flags matrix
knutwalker Jul 17, 2024
82d6aae
Update Neo4j versions for testing
knutwalker Jul 17, 2024
37129a0
Only check MSRV/beta on ubuntu
knutwalker Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ env:
jobs:
check:
name: Compile on MSRV
strategy:
fail-fast: false
matrix:
flags: ['', --all-features]
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand All @@ -41,7 +45,7 @@ jobs:
- name: Prepare MSRV lockfile
run: cp ci/Cargo.lock.msrv Cargo.lock
- name: Run cargo check
run: cargo +$MSRV check --all-targets --locked
run: cargo +$MSRV check --all-targets --locked ${{ matrix.flags }}

fmt:
name: Check formatting
Expand All @@ -63,6 +67,10 @@ jobs:

clippy:
name: Check clippy
strategy:
fail-fast: false
matrix:
flags: ['', --all-features]
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand All @@ -79,15 +87,26 @@ jobs:
- name: Prepare MSRV lockfile
run: cp ci/Cargo.lock.msrv Cargo.lock
- name: Run clippy
run: cargo +$MSRV clippy --all-targets --all-features --locked -- -D warnings
run: cargo +$MSRV clippy --all-targets --locked ${{ matrix.flags }} -- -D warnings

unit-tests:
name: Run unit tests
strategy:
fail-fast: false
matrix:
os: [windows-latest, macOS-latest, ubuntu-latest]
rust: [stable, beta, 1.63.0]
rust: [stable]
flags: ['', --all-features]
include:
- os: ubuntu-latest
rust: 1.63.0
flags: ''
- os: ubuntu-latest
rust: 1.63.0
flags: '--all-features'
- os: ubuntu-latest
rust: beta
flags: '--all-features'
runs-on: ${{ matrix.os }}
steps:
- name: Checkout code
Expand All @@ -106,14 +125,15 @@ jobs:
run: cp ci/Cargo.lock.msrv Cargo.lock
if: matrix.rust == '1.63.0'
- name: Run unit tests
run: cargo +${{ matrix.rust }} nextest run --lib --all-features
run: cargo +${{ matrix.rust }} nextest run --lib ${{ matrix.flags }}

integration-tests:
name: Run integration tests
strategy:
fail-fast: false
matrix:
neo4j: ["5.12", "5.11", "5.10", "5.9", "5.8", "5.7", "4.4", "4.3", "4.2", "4.1"]
neo4j: ["5.21", "5.20", "5.19", "4.4"]
flags: ['', --all-features]
runs-on: ubuntu-latest
steps:
- name: Checkout code
Expand All @@ -133,7 +153,7 @@ jobs:
- name: Prepare MSRV lockfile
run: cp ci/Cargo.lock.msrv Cargo.lock
- name: Run integration tests
run: env NEO4J_VERSION_TAG=${{ matrix.neo4j }} cargo +$MSRV nextest run --all-features --locked
run: env NEO4J_VERSION_TAG=${{ matrix.neo4j }} cargo +$MSRV nextest run --locked ${{ matrix.flags }}

msrv:
name: Validate MSRV and minimal dependency versions
Expand Down