Add tx termination tests #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/txtermination
branch
2 times, most recently
from
b00eda3 to
05b3698
Compare
bigmontz
reviewed
Jun 28, 2023
bigmontz
reviewed
Jun 28, 2023
injectives
force-pushed
the
feature/txtermination
branch
4 times, most recently
from
6d5fa90 to
4c4a158
Compare
injectives
changed the title
injectives
force-pushed
the
feature/txtermination
branch
2 times, most recently
from
f2546f0 to
27632c1
Compare
These tests verify transaction and its results handling when the transaction is terminated by a failure.
injectives
force-pushed
the
feature/txtermination
branch
from
27632c1 to
02444f0
Compare
…fail_subsequent_usage_after_timeout
robsdedude
approved these changes
Jul 4, 2023
Contributor
robsdedude
left a comment
robsdedude
left a comment
There was a problem hiding this comment.
Looks good 🎬
Some small comments, but no blockers among them.
tests/stub/tx_run/scripts/tx_res0_success_res1_error_on_pull.script
Outdated
Show resolved
Hide resolved
tests/stub/configuration_hints/test_connection_recv_timeout_seconds.py
Outdated
Show resolved
Hide resolved
This was referenced Jul 5, 2023
robsdedude
added a commit
that referenced
this pull request
Jul 5, 2023
Adjustment for Go for new tests and assertions added in #574
bigmontz
added a commit
to bigmontz/neo4j-javascript-driver
that referenced
this pull request
Jul 5, 2023
Adjustment for new tests and assertions added in neo4j-drivers/testkit#574
bigmontz
added a commit
to neo4j/neo4j-javascript-driver
that referenced
this pull request
Jul 6, 2023
Adjustment for new tests and assertions added in neo4j-drivers/testkit#574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests verify transaction and its results handling when the transaction is terminated by a failure.