Skip to content

Circular reference error info in ToJson #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NGDAdmin merged 2 commits into from
Oct 10, 2024
+2 −2
Merged

Circular reference error info in ToJson #3522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba2d0ce
Circular reference error info in ToJson
Hecate2 Oct 10, 2024
664d8a6
Merge branch 'master' into circular-ref-error-info
shargon Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Neo/VM/Helper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ private static JObject ToJson(StackItem item, HashSet<StackItem> context, ref in
case Array array:
{
context ??= new HashSet<StackItem>(ReferenceEqualityComparer.Instance);
if (!context.Add(array)) throw new InvalidOperationException();
if (!context.Add(array)) throw new InvalidOperationException("Circular reference.");
maxSize -= 2/*[]*/+ Math.Max(0, (array.Count - 1))/*,*/;
JArray a = new();
foreach (StackItem stackItem in array)
Expand Down Expand Up @@ -398,7 +398,7 @@ private static JObject ToJson(StackItem item, HashSet<StackItem> context, ref in
case Map map:
{
context ??= new HashSet<StackItem>(ReferenceEqualityComparer.Instance);
if (!context.Add(map)) throw new InvalidOperationException();
if (!context.Add(map)) throw new InvalidOperationException("Circular reference.");
maxSize -= 2/*[]*/+ Math.Max(0, (map.Count - 1))/*,*/;
JArray a = new();
foreach (var (k, v) in map)
Expand Down