[Neo Core Optimization] Organize core events.#3332
Merged
Conversation
shargon
reviewed
Jun 13, 2024
| private void Initialize_Logger() | ||
| { | ||
| Utility.Logging += OnLog; | ||
| Utility.Logging += ((ILoggingHandler)this).Utility_Logging_Handler; |
Member
There was a problem hiding this comment.
Why the cast? we need to define in all the partial files the interface ILoggingHandler?
Contributor
Author
There was a problem hiding this comment.
cause to make the method private, have to implement them implicitly, making it to be used this way.... Otherwise interface will be public.
|
|
||
| namespace Neo.IEventHandlers; | ||
|
|
||
| public interface ILogHandler |
Member
There was a problem hiding this comment.
Very similar name with ILoggingHandler
Contributor
Author
There was a problem hiding this comment.
Cause they are defiend this way, one Log event one Logging event for different purpose.
shargon
approved these changes
Jun 15, 2024
cschuchardt88
approved these changes
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr defines interfaces for core event handlers. The reason of doing this is that the public event of the core is defined everywhere, and each of them has its specific parameters, making it hard to maintain. Thus having this pr to define all event handler interfaces together and added readme document to explain them.
Fixes # #3333
Type of change
How Has This Been Tested?
Run existing test
Test Configuration:
Checklist: