-
Notifications
You must be signed in to change notification settings - Fork 1k
Return expect to verify neo-cli #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
57019c4
d1eb98d
6e6ff38
c892918
2d8f882
4fb55ca
c076c7c
93f6c03
f8be919
82188cd
737336e
088eca3
4222424
8bca0a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't scripts included the
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can fix it in another pr. If @vncoelho 's purpose is bring this back to the project. Please let him just bring it back.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm agree with do it organized, why we need to create one pr for one thing and other for move it? review is for this, the solution is not create a new pr.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The problem is this pr from @vncoelho is to bring expert back, moving it somewhere is a request from @cschuchardt88 , which is not what @vncoelho wanted to do..... Why would you require/enforce @vncoelho to do a thing that is out of the scope of his pr? I am not against of making it organized, but what if @vncoelho just not willing to apply his suggestion? what we do with this pr then? close it and open another one? So my point is very simple, one pr for only one task, if you agree that we should bring expert back, and @vncoelho 's pr has fullfilled this purpose, we should be fine with this pr. You can have suggestions, but that should not be a reason of enforcing unless there is a real problem in the pr. From our past working experience, i believe having small prs (real pr that can fix problem without introducing new problem), is the only way we can make it forward. BUT, its just my personal suggestion.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. His suggestion is good anyway, I will move to the main folder.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Something I would like to highlighted is that @cschuchardt88 is using the Requested Changes too much.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I completely agree with you. This should be a common sense for most of the PRs.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Than you should be creating a |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| #!/usr/bin/expect -f | ||
| # | ||
| # This script uses expect to test neo-cli | ||
| # | ||
| set timeout 10 | ||
|
|
||
|
|
||
| # Start neo-cli | ||
| spawn dotnet out/Neo.CLI/neo-cli.dll | ||
|
|
||
| # Expect the main input prompt | ||
| expect { | ||
| "neo> " { } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| # | ||
| # Test 'create wallet' | ||
| # | ||
| send "create wallet test-wallet1.json\n" | ||
|
|
||
| expect { | ||
| "password:" { send "asd\n" } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| expect { | ||
| "password:" { send "asd\n" } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| expect { | ||
| " Address:" { } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
|
|
||
| # | ||
| # Test 'create wallet' | ||
| # | ||
| send "create wallet test-wallet2.json L2ArHTuiDL4FHu4nfyhamrG8XVYB4QyRbmhj7vD6hFMB5iAMSTf6\n" | ||
|
|
||
| expect { | ||
| "password:" { send "abcd\n" } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| expect { | ||
| "password:" { send "abcd\n" } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| expect { | ||
| "NUj249PQg9EMJfAuxKizdJwMG7GSBzYX2Y" { } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| # | ||
| # Test 'list address' | ||
| # | ||
| send "list address\n" | ||
|
|
||
| expect { | ||
| "neo> " { } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
|
|
||
| # | ||
| # Test 'create address' | ||
| # | ||
| send "create address\n" | ||
|
|
||
| expect { | ||
| "neo> " { } | ||
| "error" { exit 2 } | ||
| timeout { exit 1 } | ||
| } | ||
| exit 0 |
Uh oh!
There was an error while loading. Please reload this page.