BLS coverage result has a different name than the rest#3162
Merged
Conversation
close #3160
Member
Author
|
locally it fixed with first test #21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Module | Line | Branch | Method |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Neo.Cryptography.BLS12_381 | 83.22% | 55% | 69.2% |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Neo.ConsoleService | 15.66% | 13.04% | 19.4% |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | | Line | Branch | Method |
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | Total | 68.29% | 30.67% | 60.47% |
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | Average | 49.44% | 34.01% | 44.3% |
#21 19.95 +---------+--------+--------+--------+then after #23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Module | Line | Branch | Method |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Cryptography.BLS12_381 | 87.99% | 63% | 73.96% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.IO | 75.36% | 83.82% | 75% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.VM | 33.95% | 25.9% | 41.88% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo | 78.88% | 65.32% | 81.52% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Extensions | 78.57% | 0% | 80% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Json | 36.23% | 13.66% | 40.46% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.ConsoleService | 15.66% | 13.04% | 19.4% |
#23 26.94 +----------------------------+--------+--------+--------+ |
Member
Author
|
|
Jim8y
previously approved these changes
Feb 23, 2024
Contributor
|
LGTM |
Contributor
|
@shargon up to you. |
shargon
reviewed
Feb 23, 2024
Member
|
There is something wrong, we should do it or after the first, or in all of them, we need to check |
Member
Author
You can do it first and avoid the mv |
Member
Author
|
like the last commit, take a look @shargon let's see if the result will be the same |
shargon
reviewed
Feb 23, 2024
Co-authored-by: Shargon <shargon@gmail.com>
shargon
approved these changes
Feb 23, 2024
Member
Author
|
it worked the same way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3160