Fix: add parameter null check#3091
Closed
Jim8y wants to merge 2 commits into
Closed
Conversation
| @@ -209,6 +209,7 @@ protected internal StackItem GetScriptContainer() | |||
| /// </summary> | |||
| protected internal void RuntimeLoadScript(byte[] script, CallFlags callFlags, Array args) | |||
Member
There was a problem hiding this comment.
Dont forget args. That can be null too.
PUSHNULL
PUSHNULL
PUSHNULL
SYSCALL "System.Runtime.LoadScript"
| @@ -126,6 +126,7 @@ protected internal static StorageContext AsReadOnly(StorageContext context) | |||
| /// <returns>The value of the entry. Or <see langword="null"/> if the entry doesn't exist.</returns> | |||
| protected internal ReadOnlyMemory<byte>? Get(StorageContext context, byte[] key) | |||
Member
There was a problem hiding this comment.
StorageContext null check?
shargon
reviewed
Jan 13, 2024
Member
shargon
left a comment
shargon
left a comment
There was a problem hiding this comment.
We need neo project as nullable
shargon
reviewed
Jan 23, 2024
Member
shargon
left a comment
shargon
left a comment
There was a problem hiding this comment.
We can do it better with nullable checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr follows #3089 to thoroughly check the neo core parameter check.
Type of change
Checklist: