Fix: Editconfig by Jim8y · Pull Request #3023 · neo-project/neo

Jim8y · 2023-12-13T04:43:32Z

This pr adopts https://github.com/dotnet/roslyn editconfig to restrain the coding style.

* 'editconfig' of github.com:Liaojinghui/neo: dotnet format on new editconfig use roslyn editconfig

cschuchardt88 · 2023-12-14T15:33:52Z

Maybe to want to add #3019 to this PR, going to have big conflict on one or the other.

cschuchardt88 · 2023-12-14T18:41:53Z

+[*.{cs,vb}]
+
+# Sort using and Import directives with System.* appearing first
+dotnet_sort_system_directives_first = true


Suggested change

dotnet_sort_system_directives_first = true

dotnet_sort_system_directives_first = false

Default value is true (https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/dotnet-formatting-options)

ya but this is annoying, should be alphabetical.

Why? I think that if this is the case by default, there is a reason.

ya but this is annoying, should be alphabetical.

The same argument as my var :)

cschuchardt88 · 2023-12-20T07:03:36Z

want me to update this for @Jim8y ?

Jim8y · 2023-12-20T10:02:11Z

want me to update this for @Jim8y ?

Please

cschuchardt88 · 2023-12-20T11:32:09Z

@Jim8y I updated that test for HashCodeTest as well. It's all complete now.

Jim8y · 2023-12-20T11:51:16Z

@shargon may you please check and review this.
@superboyiii may you also check if the code rules here are reasonable.

cschuchardt88 · 2023-12-26T16:49:27Z

@shargon why did you remove globals.json? We need that for the workflow to work correctly on github, atm it compiling using dotnet 8.0 sdk. neo-devpack-dotnet had a problem with 8.0. I know this repo is capable with dotnet 8.0 at the moment. But we shouldn't be using it, if we don't update to 8.0. dotnet 8.0 has a lot of new features that are not compatible with dotnet 7.0.

shargon · 2023-12-26T16:57:21Z

@shargon why did you remove globals.json? We need that for the workflow to work correctly on github, atm it compiling using dotnet 8.0 sdk. neo-devpack-dotnet had a problem with 8.0. I know this repo is capable with dotnet 8.0 at the moment. But we shouldn't be using it, if we don't update to 8.0. dotnet 8.0 has a lot of new features that are not compatible with dotnet 7.0.

Please use a different PR for this change

cschuchardt88 · 2023-12-26T17:03:45Z

I have it in #3031 also, but my thoughts were, this PR would come 1st.

* master: Fixed asp.net core project (neo-project#3067) Updated BLS12_381 (neo-project#3074) avoid nonsense exception messages. (neo-project#3063) Removed `MyGet` (neo-project#3071) Updated unit-test (neo-project#3073) add hash verification for OnImport (neo-project#3070) Make public ReadUserInput (neo-project#3068) Removed asp.net core (neo-project#3065) Enforce Line Endings in `.editorconfig` (neo-project#3060) Remove some warnings (neo-project#3057) Fixed workflow timeout-minutes (neo-project#3048) Fix: specify the error message (neo-project#3030) Removes `WebSocket`s from the network layer (neo-project#3039) set timeout for tests (neo-project#3046) Fix: Editconfig (neo-project#3023) Set project as nullable (neo-project#3042) Fix: fix equal (neo-project#3028) # Conflicts: # src/Neo.CLI/CLI/MainService.cs # src/Neo.CLI/Settings.cs # src/Neo/ProtocolSettings.cs

Jim8y and others added 7 commits December 13, 2023 12:40

use roslyn editconfig

8605a74

dotnet format on new editconfig

5775201

Merge branch 'master' into editconfig

bff3bc0

use roslyn editconfig

02a63b3

dotnet format on new editconfig

7288ae1

Merge branch 'editconfig' of github.com:Liaojinghui/neo into editconfig

b2777e7

* 'editconfig' of github.com:Liaojinghui/neo: dotnet format on new editconfig use roslyn editconfig

ignore IDE0060

ee631e9

cschuchardt88 reviewed Dec 13, 2023

View reviewed changes

Comment thread .editorconfig Outdated

Comment thread .editorconfig

Comment thread benchmarks/Neo.Benchmarks/Benchmarks.cs Outdated

Jim8y commented Dec 13, 2023

View reviewed changes

Comment thread .editorconfig Outdated

Update .editorconfig

c9b156d

Jim8y commented Dec 13, 2023

View reviewed changes

Comment thread .editorconfig

Update .editorconfig

ecab6a4

Jim8y commented Dec 13, 2023

View reviewed changes

Comment thread .editorconfig

Jimmy and others added 3 commits December 14, 2023 07:59

Update .editorconfig

e6303e9

Merge branch 'master' into editconfig

f70cbff

fix format

cdaf882

cschuchardt88 reviewed Dec 14, 2023

View reviewed changes

Merge branch 'master' into editconfig

3678178

cschuchardt88 added 3 commits December 20, 2023 06:11

Run code clean up with fixes

7656b57

Fixed code format of code

63c1b7a

Fixed readonly warnings

cd8701c

shargon reviewed Dec 25, 2023

View reviewed changes

Comment thread .editorconfig Outdated

Comment thread .editorconfig Outdated

cschuchardt88 added 2 commits December 25, 2023 06:41

shargon's fixes

e549f25

Merge branch 'master' into editconfig

6ab1e8c

shargon reviewed Dec 25, 2023

View reviewed changes

Comment thread src/Neo/Wallets/Wallet.cs Outdated

shargon added 2 commits December 26, 2023 09:52

Remove goto

33d147d

Remove globals.json

05600d2

shargon reviewed Dec 26, 2023

View reviewed changes

Comment thread .editorconfig

shargon and others added 3 commits December 27, 2023 00:59

Merge branch 'master' into editconfig

0541ca1

Merge branch 'master' into editconfig

b36c38d

Merge branch 'master' into editconfig

32d2393

shargon approved these changes Jan 2, 2024

View reviewed changes

shargon merged commit 13f506c into neo-project:master Jan 2, 2024

Jim8y deleted the editconfig branch January 2, 2024 16:13

cschuchardt88 mentioned this pull request May 8, 2024

[Refactor] Added Prefer var everywhere #3216

Closed

8 tasks

	dotnet_sort_system_directives_first = true
	dotnet_sort_system_directives_first = false

Uh oh!

Conversation

Jim8y commented Dec 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cschuchardt88 commented Dec 14, 2023

Uh oh!

cschuchardt88 Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

shargon Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

cschuchardt88 Dec 15, 2023

Choose a reason for hiding this comment

Uh oh!

shargon Dec 25, 2023

Choose a reason for hiding this comment

Uh oh!

shargon Jan 2, 2024

Choose a reason for hiding this comment

Uh oh!

cschuchardt88 commented Dec 20, 2023

Uh oh!

Jim8y commented Dec 20, 2023

Uh oh!

cschuchardt88 commented Dec 20, 2023

Uh oh!

Jim8y commented Dec 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cschuchardt88 commented Dec 26, 2023

Uh oh!

shargon commented Dec 26, 2023

Uh oh!

cschuchardt88 commented Dec 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants