Skip to content

Remove static methods: Size#8

Closed
shargon wants to merge 5 commits into
masterfrom
remove-static-size
Closed

Remove static methods: Size#8
shargon wants to merge 5 commits into
masterfrom
remove-static-size

Conversation

@shargon
Copy link
Copy Markdown
Member

@shargon shargon commented Jan 5, 2024

In order to improve the dotnet standard migration and reduce the risk changes, I want to remove the static methods one by one

In this PR:

  • Remove INumber.Size

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 5, 2024

Pull Request Test Coverage Report for Build 7420570764

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 81.641%

Totals Coverage Status
Change from base Build 3779439269: 0.04%
Covered Lines: 2034
Relevant Lines: 2428

💛 - Coveralls

@shargon shargon requested a review from Jim8y January 5, 2024 10:21
@cschuchardt88
Copy link
Copy Markdown
Member

cschuchardt88 commented Jan 5, 2024

The Your code is supported in dotnet standard. Please check the #6 and download it or you try converting to 'netstandard2.1. You will find that that the interfaces are the problem. Not static methods, only interfaces can't have static methods. Tons more code was changed than just static methods. I dont see it being a problem or a performance issue. This library is only used in ApplicationEngine for the syscalls. Plus ApplicationEngine uses tons of reflection to call syscall

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Jan 6, 2024

The Your code is supported in dotnet standard. Please check the #6 and download it or you try converting to 'netstandard2.1. You will find that that the interfaces are the problem. Not static methods, only interfaces can't have static methods. Tons more code was changed than just static methods. I dont see it being a problem or a performance issue. This library is only used in ApplicationEngine for the syscalls. Plus ApplicationEngine uses tons of reflection to call syscall

That's why I want to remove the static methods in the interface.

@shargon
Copy link
Copy Markdown
Member Author

shargon commented Jan 6, 2024

Closed in favor of #11

@shargon shargon closed this Jan 6, 2024
@shargon shargon deleted the remove-static-size branch January 6, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants