Fix: regression run after failure #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 49.27% 57.50% +8.23%
==========================================
Files 23 32 +9
Lines 2401 4594 +2193
==========================================
+ Hits 1183 2642 +1459
- Misses 1090 1729 +639
- Partials 128 223 +95
Continue to review full report at Codecov.
|
ZauberNerd
approved these changes
Jan 27, 2022
KnisterPeter
approved these changes
Jan 27, 2022
Member
|
@ChristopherHX Thanks for taking care. We where not fully aware that our change was breaking the cleanup. |
catthehacker
approved these changes
Jan 27, 2022
ZauberNerd
added a commit
to ZauberNerd/act
that referenced
this pull request
Feb 22, 2022
Errors should always be logged with an error level and not debug level. Since the error is returned here, it will be logged later as an error. Presumably this was a leftover from debugging the executor chain in: PR: nektos#971
mergify bot
added a commit
that referenced
this pull request
Feb 25, 2022
* refactor: remove debug error output Errors should always be logged with an error level and not debug level. Since the error is returned here, it will be logged later as an error. Presumably this was a leftover from debugging the executor chain in: PR: #971 * refactor: debug log wich expression is going to be evaluated * fix: handle nil in EvalBool We've seen this issue when the env map is not set-up properly, i.e. when the env map is nil, EvalBool might return nil, which should be handled as a falsy value. * fix: fail on error in if expression and return the evaluation error Stop running the workflow in case an expression cannot be evaluated. Fixes: #1008 * fix: remove quotes from inside expression syntax in test It looks like having an expression inside double quotes inside the expression syntax is not valid: https://github.com/ZauberNerd/act-test/actions/runs/1881986429 The workflow is not valid. .github/workflows/test.yml (Line: 10, Col: 13): Unexpected symbol: '"endsWith'. Located at position 1 within expression: "endsWith('Hello world', 'ld')" * refactor: export IsTruthy function from exprparser package * refactor: use IsTruthy function in EvalBool * refactor: move debug log for expression rewrite to rewrite function Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the old behavior of the then executor. A lot of code in act relies on the fact that the pipeline executor fails fast instead of failing later.
Here a list of regressions
This broke error handling of act. I prefer to revert this function to it's previous version and create a new finally executor to archive the same in a less error prone.
Also print the error of the step, since it is useful to know why my action failed. E.g. if you used continue-on-error in a composite action.
Resolves #946
@KnisterPeter @ZauberNerd You introduced the regression in 1891c72
The observation of the edit of this comment #948 (comment) is caused by the same regression, job failure without reason.