Skip to content

chore: change flag configuration for kollama command#45

Merged
nekomeowww merged 1 commit intonekomeowww:mainfrom
Fleezesd:main
Feb 18, 2025
Merged

chore: change flag configuration for kollama command#45
nekomeowww merged 1 commit intonekomeowww:mainfrom
Fleezesd:main

Conversation

@Fleezesd
Copy link
Contributor

This PR introduces an alternative approach for flag configuration in both deploy and expose commands

changes

  • Add direct flag setup capability in NewCmdDeploy and NewCmdExpose
  • Keep existing AddFlags methods for backward compatibility
  • Maintain consistent flag configuration patterns across commands
  • Prepare groundwork for future command structure improvements

Testing:

  • [ ✅] Verify all command line flags work as expected
  • [ ✅] Test deploy command with both flag setup methods
  • [ ✅] Test expose command with both flag setup methods
  • [ ✅] Ensure all existing functionality remains intact

@Fleezesd
Copy link
Contributor Author

@nekomeowww please take time to review code thks!

@nekomeowww nekomeowww merged commit 2955443 into nekomeowww:main Feb 18, 2025
1 check passed
@nekomeowww
Copy link
Owner

Released already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants