Prevent failures when user do not use vars dirs#337
Merged
Conversation
Signed-off-by: Jeremy JACQUE <jeremy.jacque@algolia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The provisioner was attempting to copy
group_varsandhost_varsdirectories to the test VM unconditionally, causing failures when these directories don't exist in the Ansible repository.Solution
Added existence checks before copying these directories in the
prepare_commandmethodImpact
Users can now run kitchen-ansible without requiring
group_varsorhost_varsdirectoriesPrevents unnecessary copy failures during VM preparation phase