Skip to content

fix(ci): run gated test jobs during staging CI#956

Merged
henrypark133 merged 1 commit intostagingfrom
fix/test-jobs-run-on-staging-ci
Mar 11, 2026
Merged

fix(ci): run gated test jobs during staging CI#956
henrypark133 merged 1 commit intostagingfrom
fix/test-jobs-run-on-staging-ci

Conversation

@henrypark133
Copy link
Copy Markdown
Collaborator

Summary

  • Four test jobs (telegram-tests, windows-build, wasm-wit-compat, docker-build) were skipped during staging CI because their if conditions only matched push and pull_request events
  • When staging-ci.yml calls test.yml via workflow_call, github.event_name is schedule (inherited from the caller), matching neither condition
  • Inverted the conditions to blocklist the one case we want to skip (PRs targeting staging) instead of allowlisting specific events

Test plan

  • Verify the four jobs run on the next scheduled staging CI (or manual workflow_dispatch)
  • Verify the jobs are still skipped on PRs targeting staging
  • Verify the jobs still run on PRs targeting main and pushes to main

🤖 Generated with Claude Code

The telegram-tests, windows-build, wasm-wit-compat, and docker-build
jobs were skipped during staging CI because their `if` conditions only
matched `push` and `pull_request` events. When staging-ci.yml calls
test.yml via workflow_call, github.event_name is `schedule` (inherited
from the caller), which matched neither condition.

Invert the conditions to blocklist the one case we want to skip (PRs
targeting staging) instead of allowlisting specific events. This handles
schedule, workflow_dispatch, and any future trigger types.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 11, 2026 19:10
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added scope: ci CI/CD workflows size: S 10-49 changed lines risk: medium Business logic, config, or moderate-risk modules contributor: core 20+ merged PRs labels Mar 11, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the gating logic in the reusable test.yml workflow so that certain “gated” jobs also run when the workflow is invoked from staging CI via workflow_call (e.g., scheduled / manual runs), while still skipping those jobs for PRs targeting staging.

Changes:

  • Updated job-level if: conditions for four gated jobs to skip only the “PR targeting staging” case.
  • Ensures the gated jobs run under non-pull_request triggers (including staging CI’s scheduled / dispatch runs).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@henrypark133 henrypark133 merged commit f08220d into staging Mar 11, 2026
12 of 13 checks passed
@henrypark133 henrypark133 deleted the fix/test-jobs-run-on-staging-ci branch March 11, 2026 21:04
@github-actions github-actions bot mentioned this pull request Mar 11, 2026
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
The telegram-tests, windows-build, wasm-wit-compat, and docker-build
jobs were skipped during staging CI because their `if` conditions only
matched `push` and `pull_request` events. When staging-ci.yml calls
test.yml via workflow_call, github.event_name is `schedule` (inherited
from the caller), which matched neither condition.

Invert the conditions to blocklist the one case we want to skip (PRs
targeting staging) instead of allowlisting specific events. This handles
schedule, workflow_dispatch, and any future trigger types.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: ci CI/CD workflows size: S 10-49 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants