fix(ci): run gated test jobs during staging CI#956
Merged
henrypark133 merged 1 commit intostagingfrom Mar 11, 2026
Merged
Conversation
The telegram-tests, windows-build, wasm-wit-compat, and docker-build jobs were skipped during staging CI because their `if` conditions only matched `push` and `pull_request` events. When staging-ci.yml calls test.yml via workflow_call, github.event_name is `schedule` (inherited from the caller), which matched neither condition. Invert the conditions to blocklist the one case we want to skip (PRs targeting staging) instead of allowlisting specific events. This handles schedule, workflow_dispatch, and any future trigger types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the gating logic in the reusable test.yml workflow so that certain “gated” jobs also run when the workflow is invoked from staging CI via workflow_call (e.g., scheduled / manual runs), while still skipping those jobs for PRs targeting staging.
Changes:
- Updated job-level
if:conditions for four gated jobs to skip only the “PR targeting staging” case. - Ensures the gated jobs run under non-
pull_requesttriggers (including staging CI’s scheduled / dispatch runs).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nickpismenkov
approved these changes
Mar 11, 2026
Merged
bkutasi
pushed a commit
to bkutasi/ironclaw
that referenced
this pull request
Mar 28, 2026
The telegram-tests, windows-build, wasm-wit-compat, and docker-build jobs were skipped during staging CI because their `if` conditions only matched `push` and `pull_request` events. When staging-ci.yml calls test.yml via workflow_call, github.event_name is `schedule` (inherited from the caller), which matched neither condition. Invert the conditions to blocklist the one case we want to skip (PRs targeting staging) instead of allowlisting specific events. This handles schedule, workflow_dispatch, and any future trigger types. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telegram-tests,windows-build,wasm-wit-compat,docker-build) were skipped during staging CI because theirifconditions only matchedpushandpull_requesteventsstaging-ci.ymlcallstest.ymlviaworkflow_call,github.event_nameisschedule(inherited from the caller), matching neither conditionTest plan
workflow_dispatch)🤖 Generated with Claude Code