test: add event-trigger routine e2e coverage#1088
Merged
henrypark133 merged 1 commit intostagingfrom Mar 13, 2026
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds E2E test coverage for event-trigger routines, specifically testing that Telegram-scoped and channel-agnostic event routines correctly fire when matching incoming messages are received.
Changes:
- Two new LLM trace fixtures for Telegram-scoped and any-channel event routines
- A shared
wait_for_routine_runpolling helper and two new test functions ine2e_advanced_traces.rs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/fixtures/llm_traces/advanced/routine_event_telegram.json | LLM trace fixture for a Telegram-scoped event routine creation and trigger |
| tests/fixtures/llm_traces/advanced/routine_event_any_channel.json | LLM trace fixture for a channel-agnostic event routine creation and trigger |
| tests/e2e_advanced_traces.rs | Adds wait_for_routine_run helper and two new E2E tests verifying event routine triggers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zmanian
approved these changes
Mar 13, 2026
Collaborator
zmanian
left a comment
There was a problem hiding this comment.
Good test coverage for event-trigger routines. The channel-scoped and any-channel variants cover the important edge cases. Clean fixture setup. LGTM.
ilblackdragon
pushed a commit
that referenced
this pull request
Mar 14, 2026
This was referenced Mar 16, 2026
Merged
bkutasi
pushed a commit
to bkutasi/ironclaw
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan