Skip to content

test: add event-trigger routine e2e coverage#1088

Merged
henrypark133 merged 1 commit intostagingfrom
codex-routine-event-trigger-tests
Mar 13, 2026
Merged

test: add event-trigger routine e2e coverage#1088
henrypark133 merged 1 commit intostagingfrom
codex-routine-event-trigger-tests

Conversation

@henrypark133
Copy link
Copy Markdown
Collaborator

Summary

  • add E2E coverage for Telegram-scoped event routines
  • add E2E coverage for event routines without an event_channel filter
  • verify that matching incoming Telegram messages create routine runs and broadcast routine output

Test Plan

  • cargo test --test e2e_advanced_traces routine_event_trigger --features libsql

Copilot AI review requested due to automatic review settings March 12, 2026 23:38
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions bot added size: L 200-499 changed lines risk: low Changes to docs, tests, or low-risk modules contributor: core 20+ merged PRs labels Mar 12, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds E2E test coverage for event-trigger routines, specifically testing that Telegram-scoped and channel-agnostic event routines correctly fire when matching incoming messages are received.

Changes:

  • Two new LLM trace fixtures for Telegram-scoped and any-channel event routines
  • A shared wait_for_routine_run polling helper and two new test functions in e2e_advanced_traces.rs

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/fixtures/llm_traces/advanced/routine_event_telegram.json LLM trace fixture for a Telegram-scoped event routine creation and trigger
tests/fixtures/llm_traces/advanced/routine_event_any_channel.json LLM trace fixture for a channel-agnostic event routine creation and trigger
tests/e2e_advanced_traces.rs Adds wait_for_routine_run helper and two new E2E tests verifying event routine triggers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@zmanian zmanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test coverage for event-trigger routines. The channel-scoped and any-channel variants cover the important edge cases. Clean fixture setup. LGTM.

@henrypark133 henrypark133 merged commit 1bc10fe into staging Mar 13, 2026
14 checks passed
@henrypark133 henrypark133 deleted the codex-routine-event-trigger-tests branch March 13, 2026 18:24
@ironclaw-ci ironclaw-ci bot mentioned this pull request Mar 17, 2026
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: low Changes to docs, tests, or low-risk modules size: L 200-499 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants