Skip to content

style: fix formatting in cli/mod.rs and mcp/auth.rs#1071

Merged
zmanian merged 3 commits intostagingfrom
fix/staging-fmt-cleanup
Mar 12, 2026
Merged

style: fix formatting in cli/mod.rs and mcp/auth.rs#1071
zmanian merged 3 commits intostagingfrom
fix/staging-fmt-cleanup

Conversation

@zmanian
Copy link
Copy Markdown
Collaborator

@zmanian zmanian commented Mar 12, 2026

Summary

  • Fix import ordering in src/cli/mod.rs (routines module inserted out of alphabetical order)
  • Fix formatting in src/tools/mcp/auth.rs

These pre-existing fmt issues on staging are causing CI failures on all open PRs.

Test plan

  • cargo fmt --check passes

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@zmanian zmanian enabled auto-merge (squash) March 12, 2026 19:53
@github-actions github-actions bot added size: S 10-49 changed lines scope: channel/cli TUI / CLI channel scope: tool/mcp MCP client risk: medium Business logic, config, or moderate-risk modules and removed size: S 10-49 changed lines labels Mar 12, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical formatting inconsistencies that were disrupting the continuous integration pipeline. By reordering imports in src/cli/mod.rs and applying standard formatting to src/tools/mcp/auth.rs, it ensures that cargo fmt --check passes, thereby unblocking other development efforts and stabilizing the staging environment.

Highlights

  • Import Ordering: Corrected the alphabetical ordering of module imports and pub use statements for the routines module in src/cli/mod.rs.
  • Code Formatting: Applied consistent formatting to a test case in src/tools/mcp/auth.rs, specifically reformatting an array of string literals.
  • CI Stability: Resolved pre-existing formatting issues that were causing continuous integration (CI) failures on other open pull requests.
Changelog
  • src/cli/mod.rs
    • Reordered mod routines; declaration to maintain alphabetical order.
    • Moved pub use routines::... statement to its correct alphabetical position.
  • src/tools/mcp/auth.rs
    • Applied cargo fmt to reformat an array of string literals within a test function for improved readability.
Activity
  • Initial commit addressing formatting issues.
  • Co-authored by Claude Opus 4.6, indicating AI assistance in the development process.
  • Verified changes with cargo fmt --check to ensure compliance with formatting standards.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added the contributor: core 20+ merged PRs label Mar 12, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses formatting issues in src/cli/mod.rs and src/tools/mcp/auth.rs. The changes correctly reorder module and use statements for alphabetical consistency and adjust array formatting to align with standard Rust style, likely to satisfy cargo fmt. These changes are appropriate and resolve the described CI failures.

…s create

The routines CLI create command was missing the new Lightweight fields
added after the cron->routines rename merged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the size: S 10-49 changed lines label Mar 12, 2026
Fixes items_after_test_module lint by moving the test module to the
end of the file, after all production structs and impls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added size: S 10-49 changed lines scope: tool/builtin Built-in tools size: M 50-199 changed lines and removed size: S 10-49 changed lines labels Mar 12, 2026
@zmanian zmanian merged commit 8ac24e7 into staging Mar 12, 2026
10 checks passed
@zmanian zmanian deleted the fix/staging-fmt-cleanup branch March 12, 2026 20:21
@ironclaw-ci ironclaw-ci bot mentioned this pull request Mar 12, 2026
bkutasi pushed a commit to bkutasi/ironclaw that referenced this pull request Mar 28, 2026
* style: fix formatting in cli/mod.rs and mcp/auth.rs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(cli): add missing use_tools and max_tool_rounds fields to routines create

The routines CLI create command was missing the new Lightweight fields
added after the cron->routines rename merged.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(clippy): move path_routing_tests after production code in memory.rs

Fixes items_after_test_module lint by moving the test module to the
end of the file, after all production structs and impls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor: core 20+ merged PRs risk: medium Business logic, config, or moderate-risk modules scope: channel/cli TUI / CLI channel scope: tool/builtin Built-in tools scope: tool/mcp MCP client size: M 50-199 changed lines size: S 10-49 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants