call class serialize/deserialize methods#20
Merged
mehtaphysical merged 2 commits intomasterfrom May 27, 2021
Merged
Conversation
9 tasks
ailisp
reviewed
May 21, 2021
| "dependencies": { | ||
| "@types/bn.js": "^4.11.5", | ||
| "bn.js": "^5.0.0", | ||
| "bn.js": "^5.2.0", |
ailisp
reviewed
May 21, 2021
lib/index.js
Outdated
| } | ||
| function serializeStruct(schema, obj, writer) { | ||
| if (typeof obj.serialize === 'function') { | ||
| obj.serialize(writer); |
Member
There was a problem hiding this comment.
I would prefer obj.borshSerialize/obj.borshDeserialize for a less chance of name collision
ailisp
approved these changes
May 21, 2021
Member
ailisp
left a comment
There was a problem hiding this comment.
Code change looks good to me, @volovyk-s do you think the API change makes sense?
volovyks
requested changes
May 25, 2021
Contributor
volovyks
left a comment
There was a problem hiding this comment.
Looks good overall. Let's add simple unit tests and merge this PR.
volovyks
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
This allows for something like: