Skip to content

avoid redundant toList-calls #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2024
Merged

avoid redundant toList-calls #1569

merged 2 commits into from
Aug 26, 2024

Conversation

@jvoigtlaender
Copy link
Contributor

@jvoigtlaender jvoigtlaender commented Feb 4, 2024

This is per the hint

If the entire list is intended to be reduced via a fold, just fold the structure directly bypassing the list.

from the documentation: https://hackage.haskell.org/package/base-4.19.0.0/docs/Data-Foldable.html#v:toList

@jvoigtlaender jvoigtlaender mentioned this pull request Feb 5, 2024
Open
@ndmitchell ndmitchell merged commit 6ee004e into ndmitchell:master Aug 26, 2024
ndmitchell added a commit that referenced this pull request Aug 26, 2024
@ndmitchell
#1569, update the changelog
2ef7449 
Summary:

Test Plan:
@jvoigtlaender jvoigtlaender deleted the toList branch August 26, 2024 15:00
@jvoigtlaender jvoigtlaender mentioned this pull request Nov 3, 2024
Merged
cgohla pushed a commit to cgohla/hlint that referenced this pull request Jun 8, 2025
@ndmitchell @cgohla
ndmitchell#1569, update the changelog
498e097 
Summary:

Test Plan:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jvoigtlaender @ndmitchell